Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rln-relay): handle invalid deletes #1717

Merged
merged 1 commit into from
May 5, 2023
Merged

fix(rln-relay): handle invalid deletes #1717

merged 1 commit into from
May 5, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented May 5, 2023 •
edited

Description

After deletion behaviour in zerokit's master was changed, it caused ci errors in nwaku. This PR addresses that change in behaviour.

Changes

  • Updated tests to include a valid deletion operation

@rymnc rymnc self-assigned this May 5, 2023
@rymnc rymnc requested a review from alrevuelta May 5, 2023 08:56
alrevuelta
alrevuelta approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix! lgtm!

@rymnc rymnc merged commit 81dffee into master May 5, 2023
16 checks passed
@rymnc rymnc deleted the fix-failing-tests branch May 5, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alrevuelta alrevuelta alrevuelta approved these changes

Assignees

@rymnc rymnc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rymnc @alrevuelta