Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): remove target flag from docker command #1725

Merged
merged 2 commits into from
May 15, 2023
Merged

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented May 11, 2023

Description

Includes a debug flag in the jenkinsfile

Changes

  • Adds the debug target, and replaces the experimental target since it doesn't exist anymore

@rymnc rymnc added the infra Infra, devops, CI and related tasks label May 11, 2023
@rymnc rymnc self-assigned this May 11, 2023
@LNSD
Copy link
Contributor

LNSD commented May 11, 2023

@rymnc Note that I suggested having a "debug tools" target in the Dockerfile (e.g., for an image including the heaptrack tool), and that would require it.

EDIT: Not specifying the target would mean you would build all the targets, and it would deploy the image that includes the debug tools.

cc @Ivansete-status

@rymnc
Copy link
Contributor Author

rymnc commented May 12, 2023

@LNSD, thanks for the catch -
I've added an additional flag in 7013911 for the debug target, so we can rollout the debug containers to all nodes in the test fleet at once if required then, if it is unset, will use the prod image.

@rymnc rymnc requested a review from jm-clius May 12, 2023 06:54
@Ivansete-status
Copy link
Collaborator

Thanks for the PR @rymnc ! However, I miss the DEBUG flag in our Makefile so that we can clearly have release by default and debug on demand.

Btw, we are generating the release binaries with debug information. We have the next for the statusteam/nim-waku:v0.16.0 package:

/ # file /usr/local/bin/wakunode2 
/usr/local/bin/wakunode2: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-musl-x86_64.so.1, with debug_info, not stripped

Was that made on purpose @jm-clius ?

@jm-clius
Copy link
Contributor

Btw, we are generating the release binaries with debug information.

Mmm. There may be something here, though I think the default build will be with -d:release as it should. Release builds should contain debugger info, just with the lighter weight libbacktrace stack tracing: https://github.com/status-im/nim-libbacktrace

@rymnc rymnc merged commit d822cdc into master May 15, 2023
11 checks passed
@rymnc rymnc deleted the fix-experimental-release branch May 15, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra, devops, CI and related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants