Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Milestone] Move Waku v1 and Waku-Bridge to new repos #1767

Closed
alrevuelta opened this issue May 29, 2023 · 4 comments · Fixed by #1898
Closed

[Milestone] Move Waku v1 and Waku-Bridge to new repos #1767

alrevuelta opened this issue May 29, 2023 · 4 comments · Fixed by #1898
Assignees
Labels
enhancement New feature or request

Comments

@alrevuelta
Copy link
Contributor

alrevuelta commented May 29, 2023

Planned start date: 1 Aug 2023
Due date: 11 Aug 2023

Summary

@jm-clius suggestion: split into three repos: waku-legacy for the (barely changing) v1 and whisper code, nwaku for v2 and waku-bridge for the bridge with both nwaku and legacy as submodules.

adding: remove v2 references, so nwaku is nwaku not nwaku/v2. perhaps both bridge and v1/whisper part of waku-legacy repo, but no strong opinion.

@jm-clius
Copy link
Contributor

Thanks for creating tracking issue. Agree re removing "v2" references.

perhaps both bridge and v1/whisper part of waku-legacy repo, but no strong opinion.

No strong opinion either, but note that this will have the weird-ish effect of "v2" with all its own complicated submodules being a submodule for the legacy repo.

@alrevuelta
Copy link
Contributor Author

No strong opinion either, but note that this will have the weird-ish effect of "v2" with all its own complicated submodules being a submodule for the legacy repo.

mm i see. then whatever is easier.

@vpavlin
Copy link
Member

vpavlin commented May 30, 2023

I would vote for 3 repos as originally suggested to make things less tangled

@jm-clius jm-clius self-assigned this Jun 6, 2023
@vpavlin vpavlin added this to the Release 0.19.0 milestone Aug 1, 2023
@jm-clius jm-clius changed the title feat: nwaku v2 cleanup [Milestone] Clean up nwaku v2 repo Aug 4, 2023
@jm-clius jm-clius added milestone Tracks a subteam milestone E:2023-qa labels Aug 4, 2023
@jm-clius
Copy link
Contributor

jm-clius commented Aug 4, 2023

Weekly Update

  • achieved: Removed v1 and wakubridge code from nwaku repo
  • next: Remove references to v2 from nwaku directory structure and documents

@fryorcraken fryorcraken changed the title [Milestone] Clean up nwaku v2 repo [Milestone] Move Waku v1 and Waku-Bridge to new repos Aug 7, 2023
@fryorcraken fryorcraken added enhancement New feature or request and removed E:2023-qa milestone Tracks a subteam milestone labels Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants