chore(ci): properly set os and architecture for nightly and release #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivansete-status
approved these changes
Jun 6, 2023
| @@ -41,8 +56,9 @@ else: | |||
| if defined(windows): | |||
| # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65782 | |||
| # ("-fno-asynchronous-unwind-tables" breaks Nim's exception raising, sometimes) | |||
| switch("passC", "-mno-avx512vl") | |||
| switch("passL", "-mno-avx512vl") | |||
| switch("passC", "-mno-avx512f") | |||
There was a problem hiding this comment.
Do we have a way to test this works?
There was a problem hiding this comment.
We are no building for Windows right now, so no, we do not really have a reasonable way to fix this. On the other hand this is "just" to prevent the compiler to enable these abx512f instructions which was the initial reason to look into this. Once we start building for Windows, we'll also want to verify the build artifacts work:) For now it is just a "dumb" copy of best practices from Nimbus:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
config.nimsaccording to findings by Nimbus about various CPU archs and options (https://github.com/status-im/nimbus-eth2/blob/stable/config.nims#L94). It also updates release workflows (Nightly and actual releases) to leverage these options.Next, it adds
arm64architecture for Mac OSX system to make the released assets run on Apple M1 hardware (cc @alrevuelta)This also reverts #1759 which was an interim solution to enable compatibility between various CPU architectures.
Lastly, it changes the name of the uploaded binary artifacts to
i.e.
See the example nightly release here: https://github.com/nwaku-test-org/nwaku/releases/tag/nightly
Changes
arm64architecture for Mac OSX system in the build matrixnativearchitecture is disabled (according to Nimbus)-march=x86_64fromMakefilenim-waku-${OS}-latest.tar.gztonwaku-${{arch}}-${{os}}.tar.gzIssue
closes #1760