Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix mac docker build alpine version #1801

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fix: fix mac docker build alpine version #1801

merged 1 commit into from
Jun 15, 2023

Conversation

alrevuelta
Copy link
Contributor

@alrevuelta alrevuelta commented Jun 15, 2023 •
edited

  • docker build . was broken in mac
  • this PR fixes it by using alpine:3.16
  • just revets back to this

Ivansete-status
Ivansete-status approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for it!

@alrevuelta alrevuelta merged commit fce845b into master Jun 15, 2023
9 checks passed
@alrevuelta alrevuelta deleted the fix-mac-docker-build branch June 15, 2023 17:17
SionoiS pushed a commit that referenced this pull request Jun 19, 2023
@alrevuelta @SionoiS
fix: fix mac docker build alpine version (#1801)
4ca44ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alrevuelta @Ivansete-status