fix(libp2p): Updating nim-libp2p to fix the wss connectivity issue
#1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `nim-libp2p` adds many changes although we are actually interested in the latest commit: > wstransport.nim: avoid re-raising 'TransportOsError' to avoid stopping `switch.accept` (#929) * The `nim-stew` bump is needed so that the `nim-libp2p` can compile. * The changes in `waku_node.nim` are needed due to the changes in `nim-stew`.
Ivansete-status
requested review from
jm-clius,
alrevuelta,
SionoiS and
fryorcraken
Ivansete-status
removed request for
SionoiS,
alrevuelta,
jm-clius and
fryorcraken
|
Please don't check it just yet. I'll add reviewers once I confirm CI passes |
Ivansete-status
force-pushed
the
fix-1831-avoid-node-stop-attending-wss-requests
branch
from
fa05e4d
to
aa9e56e
Compare
…Handler' This is aimed to avoid the next exception happening in the wakunode: ``` Unhandled defect: Async procedure (service.nim(74) callHandler) yielded `nil`, are you await'ing a `nil` Future? [AssertionDefect] ```
|
Thanks so much indeed @rymnc for shedding a lot of light on a bug that I had! I'm super happy about it! |
Ivansete-status
requested review from
jm-clius,
alrevuelta,
SionoiS,
rymnc and
vpavlin
|
NICE! that bug was very cryptic! |
|
I don't understand the fix. Do you have to yield back control to the async runtime because it block something else? |
Menduist
reviewed
Jul 13, 2023
waku/v2/node/waku_node.nim
Outdated
Comment on lines
122
to
131
| proc statusAndConfidenceHandler(networkReachability: NetworkReachability, | ||
| confidence: Opt[float]): | ||
| Future[void] {.gcsafe, raises: [].} = | ||
| if confidence.isSome(): | ||
| info "Peer reachability status", networkReachability=networkReachability, confidence=confidence.get() | ||
|
|
||
| let retFut = newFuture[void]() | ||
| retFut.complete() | ||
| return retFut | ||
|
|
There was a problem hiding this comment.
Suggested change
| proc statusAndConfidenceHandler(networkReachability: NetworkReachability, | |
| confidence: Opt[float]): | |
| Future[void] {.gcsafe, raises: [].} = | |
| if confidence.isSome(): | |
| info "Peer reachability status", networkReachability=networkReachability, confidence=confidence.get() | |
| let retFut = newFuture[void]() | |
| retFut.complete() | |
| return retFut | |
| proc statusAndConfidenceHandler(networkReachability: NetworkReachability, | |
| confidence: Opt[float]): | |
| Future[void] {.gcsafe, async.} = | |
| if confidence.isSome(): | |
| info "Peer reachability status", networkReachability=networkReachability, confidence=confidence.get() |
Sorry if I wasn't clear on discord, that is what I meant when I said "Some of the failures are because you removed the async from statusAndConfidenceHandler"
There was a problem hiding this comment.
Thanks for the comment @Menduist ! It is much better that way!
Ivansete-status
force-pushed
the
fix-1831-avoid-node-stop-attending-wss-requests
branch
from
b869d18
to
93281f9
Compare
…turns a Future[void]
|
I got confused by I get it now! |
SionoiS
approved these changes
Jul 13, 2023
Ivansete-status
deleted the
fix-1831-avoid-node-stop-attending-wss-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nim-libp2padds many changes although we are actually interested in the latest commit:The
nim-stewbump is needed so that thenim-libp2pcan compile.The changes in
waku_node.nimare needed due to the changes innim-stew.Issue
closes #1831