Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: json-rpc and rest-api handlers are doubling the caches for messages. #1910

Closed
NagyZoltanPeter opened this issue Aug 14, 2023 · 1 comment
Labels
E:REST API service node See https://github.com/waku-org/pm/issues/82 for details

Comments

@NagyZoltanPeter
Copy link
Contributor

Background

Not pretty sure if it's by design and due to by decision. I found that currently relay rest-api and json-rpc maintain different message caches and doubles to handlers to be called to cache the messages.
It is the same currently for legacy filter as well.
I think it is waste of resources and can be refactored for an optimal solution.

Details

When installing handlers on App side we are providing different cache instances for rest and rpc handlers.
Also current design does not support using same cache.

@fryorcraken fryorcraken added the E:REST API service node See https://github.com/waku-org/pm/issues/82 for details label Sep 5, 2023
@chair28980
Copy link
Contributor

Closing per discussion at nwaku pm 2024-01-02.

Issue no longer relevant after removal of json-rpc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:REST API service node See https://github.com/waku-org/pm/issues/82 for details
Projects
Archived in project
Development

No branches or pull requests

3 participants