Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): update changelog for delayed v0.19.0 release #1911

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

vpavlin
Copy link
Member

@vpavlin vpavlin commented Aug 15, 2023

Description

Updating Changelog for the (delayed) v0.19.0 release.

Please take a look at highlights and upgrade instructions and let me know if there is anything missing/incorrect.

@vpavlin vpavlin requested review from jm-clius, rymnc, SionoiS, alrevuelta and NagyZoltanPeter and removed request for jm-clius August 15, 2023 11:17
@vpavlin vpavlin changed the title chore(release) update changelog for delayed v0.19.0 release chore(release): update changelog for delayed v0.19.0 release Aug 15, 2023
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe add that --pubsub-topic replace --topic --content-topic is new and works by autosharding.

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but generally LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated

## Upgrade instructions

* The `--topic` CLI option is being depreaced in favour of two more spefici options `--pubsub-topic` and `--content-topic`. The `--topic` option will be available for next 2 releases with a deprecation note.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my notes for the same sentence at the top level.

Co-authored-by: Hanno Cornelius <68783915+jm-clius@users.noreply.github.com>
@vpavlin vpavlin merged commit 7869078 into master Aug 16, 2023
8 checks passed
@vpavlin vpavlin deleted the release/v0.19.0 branch August 16, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants