Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Sharded peer management and discovery #1919

Closed
SionoiS opened this issue Aug 18, 2023 · 3 comments
Closed

[Epic] Sharded peer management and discovery #1919

SionoiS opened this issue Aug 18, 2023 · 3 comments
Assignees
Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details Epic

Comments

@SionoiS
Copy link
Contributor

SionoiS commented Aug 18, 2023

Planned start date: 14 August
Due date: TBD

Summary

If we assume that peer discovery takes care of filtering peers by shard, these peers must be managed in a way that makes sense in a dynamic auto-sharded environment.

Acceptance Criteria

  • Node can filter discovered peers according to shards subscriptions.
  • Node update its own discoverable ENR every time its subscriptions changes.
  • peer store must preferably try to keep at least a target n peers for each subscribed shard (note that dynamically subscribing/unsubscribing from shards could complicate this)
  • peer manager must attempt to maintain a healthy relay connectivity for each subscribed shard
  • a mechanism to perform ad-hoc discovery (or another solution) to cater for when a node subscribes to a shard for which there are no tracked peers

Tasks

RAID (Risks, Assumptions, Issues and Dependencies)

@SionoiS SionoiS added milestone Tracks a subteam milestone E:2023-peer-mgmt labels Aug 18, 2023
@SionoiS
Copy link
Contributor Author

SionoiS commented Aug 18, 2023

Weekly Update

  • achieved: discv5 ENR update & filter predicate run-time updating
  • next: PRs feedback updates

@SionoiS
Copy link
Contributor Author

SionoiS commented Aug 23, 2023

Weekly Update

  • achieved: topic subscriptions update discv5 ENR and filter predicate. PRs merged.

@fryorcraken fryorcraken added Epic and removed milestone Tracks a subteam milestone labels Aug 24, 2023
@fryorcraken fryorcraken changed the title [Milestone] Sharded peer management and discovery [Epic] Sharded peer management and discovery Aug 24, 2023
@fryorcraken fryorcraken added E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details and removed E:2023-peer-mgmt labels Sep 22, 2023
@SionoiS
Copy link
Contributor Author

SionoiS commented Jan 4, 2024

Closing as it is done.

@SionoiS SionoiS closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details Epic
Projects
Status: Done
Development

No branches or pull requests

3 participants