Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rln-relay): rename keystore application to waku-rln-relay #1924

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Aug 22, 2023

Description

This PR renames the application field in the keystore to waku-rln-relay to make it agnostic to the client (go-waku,
nwaku).

cc: @richard-ramos thanks for the report

cc: @alrevuelta this may require you to manually change the application in the keystore you're using for the
simulations - sed -i s/nwaku-rln-relay/waku-rln-relay/g rlnKeystore.json

Changes

  • s/nwaku-rln-relay/waku-rln-relay

Issue

closes #1903

@rymnc rymnc self-assigned this Aug 22, 2023
@rymnc rymnc marked this pull request as ready for review August 22, 2023 05:05
@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1924

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! What is the keystore for?
Cheers

@rymnc
Copy link
Contributor Author

rymnc commented Aug 23, 2023

LGTM! What is the keystore for? Cheers
The keystore is used to provide safe storage for rln credentials

@rymnc rymnc merged commit 8239b45 into master Aug 23, 2023
12 checks passed
@rymnc rymnc deleted the rln-app-identifier branch August 23, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(rln-keystore)
3 participants