Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add a job checking config options and db schema #1927

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

vpavlin
Copy link
Member

@vpavlin vpavlin commented Aug 22, 2023

Description

This PR adds a CI job checking changes in the PR and matching them agains files which contain

  1. configuration options for apps
  2. DB schema for archive drivers

If it matches, it will post a comment nudging the submitter to check whether there is a risk for a breaking change and also suggests to use release-notes label, to make sure the change is covered in Release Notes and changelog

I tried to articulate the comments clearly, but maybe there is a better wording/suggestion to submitter, please let me know what would be the information you'd like to see in the comment.

Also, let me know if I missed any files that should make it into the lists:)

Changes

  • new CI job checking for a fixed list of files in a PR and commenting on it in case it matches

Issue

closes #1873

@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1927

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful PR! Thanks for it!

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff!

@vpavlin vpavlin merged commit 505d196 into master Aug 23, 2023
13 checks passed
@vpavlin vpavlin deleted the chore/label-config-change branch August 23, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: add an action to check for config option changes
3 participants