Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rln_keystore_generator): generate and persist credentials #1928

Merged
merged 3 commits into from
Aug 23, 2023
Merged

chore(rln_keystore_generator): generate and persist credentials #1928

merged 3 commits into from
Aug 23, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Aug 22, 2023 •
edited

Description

A follow up PR to #1925

Changes

  • Creates an instance of the rln object
  • Generates credentials
  • Uses dummy chainId, contractAddress and treeIndex to write to a keystore

The next follow up PR will actually execute the registration if --execute is true

@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1928

@rymnc rymnc marked this pull request as ready for review August 22, 2023 18:02
@rymnc rymnc self-assigned this Aug 22, 2023
Ivansete-status
Ivansete-status approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I could understand :P!
Just added minor comments

tools/rln_keystore_generator/external_config.nim Show resolved Hide resolved
tools/rln_keystore_generator/rln_keystore_generator.nim Outdated Show resolved Hide resolved
tools/rln_keystore_generator/rln_keystore_generator.nim Outdated Show resolved Hide resolved
tools/rln_keystore_generator/rln_keystore_generator.nim Show resolved Hide resolved
@rymnc rymnc merged commit 07945a3 into master Aug 23, 2023
12 checks passed
@rymnc rymnc deleted the rln-credential-tool-2 branch August 23, 2023 07:21
@rymnc rymnc mentioned this pull request Aug 23, 2023
Closed
56 tasks
@rymnc rymnc mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@alrevuelta alrevuelta alrevuelta approved these changes

@jm-clius jm-clius Awaiting requested review from jm-clius

Assignees

@rymnc rymnc

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rymnc @alrevuelta @Ivansete-status