fix(rln-relay): bump zerokit to v0.3.2 #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at |
|
@alrevuelta can you confirm that this branch does not produce the bug you mentioned? |
vpavlin
reviewed
Aug 25, 2023
| @@ -17,7 +17,7 @@ fi | |||
| host_triplet=$(rustup show | grep "Default host: " | cut -d' ' -f3) | |||
|
|
|||
| # Download the prebuilt rln library if it is available | |||
| if curl --silent --fail-with-body -L "https://github.com/vacp2p/zerokit/releases/download/v0.3.1/$host_triplet-rln.tar.gz" >> "$host_triplet-rln.tar.gz" | |||
| if curl --silent --fail-with-body -L "https://github.com/vacp2p/zerokit/releases/download/v0.3.2/$host_triplet-rln.tar.gz" >> "$host_triplet-rln.tar.gz" | |||
There was a problem hiding this comment.
Maybe an unnecessary overkill, but what about getting the version from the submodule?
Something like
$ git submodule status vendor/zerokit | awk '{print $3}' | sed 's/[()]//g'
v0.3.1
So that there is only one source of truth for the version?
There was a problem hiding this comment.
will address in a follow up pr, thanks!
vpavlin
approved these changes
Aug 25, 2023
alrevuelta
approved these changes
Aug 25, 2023
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps zerokit to v0.3.2, which includes a fix for tree persistence
Changes
build_rln.shIssue
closes #1944