Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rln-relay): deserialization of valid merkle roots #1973

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix(rln-relay): deserialization of valid merkle roots #1973

merged 1 commit into from
Aug 31, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Aug 30, 2023

Description

This PR fixes a regression introduced in #1953
Deserialization of merkle roots has been fixed

Changes

  • Fixed deserialization of merkle roots when fetching validRoots

How to test

  1. Follow bug(rln): "provided root does not belong to acceptable window of roots" #1952 (comment)

Issue

closes #1952

@rymnc rymnc self-assigned this Aug 30, 2023
@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1973

@rymnc rymnc marked this pull request as ready for review August 30, 2023 18:33
SionoiS
SionoiS approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alrevuelta
alrevuelta approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! tested locally with 0x8e1F3742B987d8BA376c0CBbD7357fE1F003ED71 and seems to work fine. Now after a restart the messages are correctly verified.

@rymnc rymnc merged commit d262837 into master Aug 31, 2023
13 checks passed
@rymnc rymnc deleted the fix-deserialization-roots branch August 31, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SionoiS SionoiS SionoiS approved these changes

@alrevuelta alrevuelta alrevuelta approved these changes

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

Assignees

@rymnc rymnc

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(rln): "provided root does not belong to acceptable window of roots"
3 participants
@rymnc @SionoiS @alrevuelta