Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow to configure RLN via the REST API #1985

Open
2 tasks
alrevuelta opened this issue Sep 4, 2023 · 1 comment
Open
2 tasks

feat: Allow to configure RLN via the REST API #1985

alrevuelta opened this issue Sep 4, 2023 · 1 comment
Labels
E:REST API service node See https://github.com/waku-org/pm/issues/82 for details effort/weeks Estimated to be completed in a few weeks

Comments

@alrevuelta
Copy link
Contributor

Allow to configure RLN via the REST API, by loading a keystore + password.

  • Allow RLN keystore to be loaded from REST API.
  • Modify API and spec if needed.

To be defined:

  • Does the rest api override the configured keystore from cli?
  • Is it persisted after restart?
  • Security implications? Passing keystore + password?

Unsure if we should develop this feature, but creating a tracker for discussion.
@alrevuelta alrevuelta mentioned this issue Sep 4, 2023
Closed
@alrevuelta
Copy link
Contributor Author

geth for example has a command to import keys, but seems they don't have an rpc endpoin to do so, unsure if the reason is security.
geth account import

in case it can serve for inspiration on wether to pursue this feature or not + alternatives.

https://geth.ethereum.org/docs/fundamentals/account-management#creating-accounts
https://geth.ethereum.org/docs/interacting-with-geth/rpc/ns-personal
https://geth.ethereum.org/docs/tools/clef/introduction

@fryorcraken fryorcraken added the E:REST API service node See https://github.com/waku-org/pm/issues/82 for details label Sep 5, 2023
@fryorcraken fryorcraken mentioned this issue Sep 13, 2023
Open
10 tasks
@Ivansete-status Ivansete-status mentioned this issue Feb 9, 2024
Merged
@Ivansete-status Ivansete-status added the effort/weeks Estimated to be completed in a few weeks label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:REST API service node See https://github.com/waku-org/pm/issues/82 for details effort/weeks Estimated to be completed in a few weeks
Projects
Waku
Status: To Do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alrevuelta @fryorcraken @Ivansete-status