Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rln-db-inspector): use valueOr pattern #2012

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fix(rln-db-inspector): use valueOr pattern #2012

merged 1 commit into from
Sep 8, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Sep 7, 2023

Description

Uses valueOr instead of isOkOr since we wish to preserve the values that the results return (not
void)

Changes

  • substitute isErr pattern for valueOr

@rymnc rymnc self-assigned this Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2012

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

You can find the experimental image built from this PR at

quay.io/wakuorg/nwaku-pr:2012-experimental

@rymnc rymnc merged commit a8095d8 into master Sep 8, 2023
14 checks passed
@rymnc rymnc deleted the fix-inspector-usage branch September 8, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpavlin vpavlin vpavlin approved these changes

@alrevuelta alrevuelta Awaiting requested review from alrevuelta

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

Assignees

@rymnc rymnc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rymnc @vpavlin