fix(rln-relay): waku_rln_number_registered_memberships metrics appropriately handled #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
force-pushed
the
fix-rln-memberships-metric
branch
from
a253e5e
to
01954e6
Compare
|
You can find the image built from this PR at Built from b3e03bb |
|
You can find the experimental image built from this PR at Built from b3e03bb |
56 tasks
|
merging since the ci failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets the number of registered memberships to the
startindex (i.e last index that was inserted) + number of commitments - commitments removedUpon startup, if we fetch the tree db, there is no way currently from the zerokit ffi api to fetch the number of members registered - hence, we set the metric based on the event thrown by the contract.
Changes
setthe value of the collectorIssue
closes #2008