Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RLN support for Nwaku-Compose #2051

Closed
chair28980 opened this issue Sep 19, 2023 · 7 comments · Fixed by waku-org/nwaku-compose#7
Closed

feat: RLN support for Nwaku-Compose #2051

chair28980 opened this issue Sep 19, 2023 · 7 comments · Fixed by waku-org/nwaku-compose#7
Assignees
Labels
blocked This issue is blocked by some other work E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details

Comments

@chair28980
Copy link
Contributor

Requirements:

Add rln metrics in grafana
Mount database volume
Add new flags for rln

migrated from waku-org/nwaku-compose#5

@alrevuelta
Copy link
Contributor

some metrics to add:

  • waku_rln_proof_verification_duration_seconds
  • waku_rln_proof_generation_duration_seconds
  • waku_rln_number_registered_memberships
  • waku_rln_invalid_messages_total_total
  • waku_rln_spam_messages_total_total

@alrevuelta
Copy link
Contributor

flags:

  --rln-relay=true \
  --rln-relay-dynamic=true \
  --rln-relay-cred-password=password \
  --rln-relay-cred-path=/xxxx.json \
  --rln-relay-tree-path=/data/rln_tree.db \
  --rln-relay-eth-contract-address=0xxxxx  \
  --rln-relay-eth-client-address=ws://xxxxx:9558

optional by now. without them the node will be able to just rely messages, not publish.

  • rln-relay-cred-password
  • rln-relay-cred-path

@Ivansete-status
Copy link
Collaborator

Notice that this feature is in the end being tackled by @gabrielmer 🔥 I re-assing that to him.

@vpavlin
Copy link
Member

vpavlin commented Sep 21, 2023

Maybe this has been discussed, but just my 2c:

  • make the whole set of parameters optional by wrapping it in a condition dependent on an env var being set (like certs setup with DOMAIN)
  • Allow passing in password, cred-path, and client-address
  • I am not sure about contract - that should not change often and if you are developing against different contract, you can always override it in EXTRA_ARGS

WDYT @alrevuelta ?

@gabrielmer
Copy link
Contributor

gabrielmer commented Sep 22, 2023

Weekly Update

  • achieved: added RLN flags run_node.sh (including the optional ones), added RLN related environment variables to docker-compose.yml, added RLN metrics' visualizations to Grafana and updated the README to account for the new changes. Improved implementation based on feedback.
  • next: test the use of optional parameters, get feedback for new version, and merge as soon as all the comments get addressed

@chair28980 chair28980 added the E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details label Sep 26, 2023
@gabrielmer
Copy link
Contributor

Weekly Update

  • achieved: finished addressing feedback
  • next: task is blocked until there's an easier method for users to register RLN credentials

@chair28980
Copy link
Contributor Author

Blocked: Need better/easier way to create RLN credentials.

@chair28980 chair28980 added the blocked This issue is blocked by some other work label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue is blocked by some other work E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants