feat: added optional filtering by shard to selectPeer()

[SionoiS]

Description

Tiny PR adding an optional shard filter when selecting a peer via peer manager.

Tracking #1941

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2063

Built from a72e6cf

[jm-clius]

LGTM for now, but wondering if we'll always have the ENR for interesting peers available? The idea of some metadata exchange protocol, for example, would allow us to discover the shards for any peer even outside of ENR encoding. In other words, we may want to also index against the shard, cluster in the peerStore so that it's not a separate filter loop.

[SionoiS]

LGTM for now, but wondering if we'll always have the ENR for interesting peers available? The idea of some metadata exchange protocol, for example, would allow us to discover the shards for any peer even outside of ENR encoding. In other words, we may want to also index against the shard, cluster in the peerStore so that it's not a separate filter loop.

I agree that sharding is not well integrated into peer management yet. I don't think that ENRs will be missing in many cases but we def should have something in place for those.