fix(archive): dburl check #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may contain changes to configuration options of one of the apps. If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed. Please also make sure the label |
|
You can find the image built from this PR at Built from 3453b30 |
Ivansete-status
requested review from
jm-clius,
SionoiS and
NagyZoltanPeter
SionoiS
approved these changes
Sep 22, 2023
|
Sorry for the mess. I need first to submit a PR where the This can't be merged yet. |
NagyZoltanPeter
approved these changes
Sep 22, 2023
Ivansete-status
force-pushed
the
fix-dburl-check
branch
from
623c64a
to
23fd599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to make the database URL regex to accept
.and-within the hostname.Also, the user and password fields can be anything not empty.
notes:
apps/wakunode2/external_config.nim.How to test
nwakuwith--store-message-db-url = "postgres://nim-waku-user:nim-waku-pass@store-db-01.do-ams3.shards.test.wg:5432/postgres".Issue
status-im/infra-shards#8 (comment)