Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter discv5 bootstrap nodes by shard #2073

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Sep 22, 2023

Description

When discv5 is initialized the bootstrap nodes passed are now filtered by the same predicate used for filtering peers found during random DHT walks.

Fix #2054

@SionoiS SionoiS added the E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details label Sep 22, 2023
@SionoiS SionoiS self-assigned this Sep 22, 2023
@SionoiS SionoiS marked this pull request as ready for review September 22, 2023 19:21
@SionoiS SionoiS changed the title fix: filter discv5 bootstrap node by shard fix: filter discv5 bootstrap nodes by shard Sep 22, 2023
@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2073

Built from 9964d07

@SionoiS SionoiS merged commit d178105 into master Sep 26, 2023
11 of 12 checks passed
@SionoiS SionoiS deleted the fix--filter-discv5-bootstrap-node-by-shard branch September 26, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: nwaku connects to nodes in other cluster when using dns-disc
3 participants