Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding -d:postgres flag when creating a Docker image for release and PRs #2076

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

Ivansete-status
Copy link
Collaborator

@Ivansete-status Ivansete-status commented Sep 25, 2023

Description

The -d:postgres Nim flag was added in order to not build the Postgres archive driver when a new user wanted to compile the wakunode from the command line manually. However, we do want to have Postgres support on each Docker image, both in releases and in PRs.

Changes

  • Addition of -d:postgres in .github/workflows/container-image.yml.
  • Addition of -d:postgres in ci/Jenkinsfile.prs.
  • Addition of -d:postgres in ci/Jenkinsfile.release.
  • Addition of -d:postgres in .github/workflows/pre-release.yml.
  • Addition of -d:postgres in .github/workflows/release-assets.yml.

@Ivansete-status Ivansete-status marked this pull request as ready for review September 25, 2023 16:09
@github-actions
Copy link

github-actions bot commented Sep 25, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2076

Built from a1c3076

@Ivansete-status Ivansete-status self-assigned this Sep 25, 2023
@Ivansete-status
Copy link
Collaborator Author

Thanks @vpavlin for this recommendation 90be916 🚀 !

Copy link
Member

@vpavlin vpavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this covers all "release" assets - images and binaries + dev/test images built from PRs

One question though - why are you using -d:postgres and not POSTGRES=1 like with ci.yml?

@Ivansete-status
Copy link
Collaborator Author

One question though - why are you using -d:postgres and not POSTGRES=1 like with ci.yml?

Thanks for the review!
The POSTGRES=1 passed to the make has the same result, i.e. adding the -d:postgres as an additional NIM_PARAMS. This PR only introduces -d:postgres directly to make itself more consistent because, for e.g., the ci/Jenkinsfile.release only accepts NIM_PARAMS.

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks ok!

@Ivansete-status Ivansete-status merged commit 7a376f5 into master Sep 26, 2023
11 of 12 checks passed
@Ivansete-status Ivansete-status deleted the postgres-in-docker-img-by-default branch September 26, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants