Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relay openapi definitions #2081

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Sep 26, 2023

Description

Forgot to update openapi.yml for the new autosharding relay API in #1983

I also removed the topic when auto posting as it's already included in the message itself.

@SionoiS SionoiS self-assigned this Sep 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 26, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2081

Built from b4922d8

waku/waku_api/rest/relay/openapi.yaml Outdated Show resolved Hide resolved
waku/waku_api/rest/relay/openapi.yaml Outdated Show resolved Hide resolved
@SionoiS SionoiS marked this pull request as ready for review September 26, 2023 14:36
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After all its all good, except those two typo.

waku/waku_api/rest/relay/openapi.yaml Outdated Show resolved Hide resolved
waku/waku_api/rest/relay/openapi.yaml Outdated Show resolved Hide resolved
@SionoiS
Copy link
Contributor Author

SionoiS commented Sep 26, 2023

I hate it when I have no tool to type check everything!

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool! Thank you and for your patience on my late request!
Its unfortunate such a small change requires that much code to be changed.

@SionoiS
Copy link
Contributor Author

SionoiS commented Sep 26, 2023

Super cool! Thank you and for your patience on my late request! Its unfortunate such a small change requires that much code to be changed.

Many thanks to you. You the one working late not me :P

@SionoiS SionoiS merged commit 56dbe2a into master Sep 26, 2023
9 of 10 checks passed
@SionoiS SionoiS deleted the fix--relay-openapi-definitions branch September 26, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants