chore(cbindings): cbindings rust simple libwaku integration example #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivansete-status
requested review from
richard-ramos,
arnetheduck and
SionoiS
|
You can find the image built from this PR at Built from fd7bcec |
SionoiS
approved these changes
Sep 28, 2023
Comment on lines
+52
to
+49
| let buffer_utf8 = | ||
| String::from_utf8(slice::from_raw_parts(buffer as *mut u8, buffer_len) | ||
| .to_vec()) | ||
| .expect("valid utf8"); |
There was a problem hiding this comment.
You could do the allocation later in the closure. Using str::from_utf8 here instead.
examples/rust/src/main.rs
Outdated
| ); | ||
|
|
||
| // Extracting the current waku version | ||
| let version: Arc<RefCell<String>> = Arc::new(RefCell::new(String::from(""))); |
There was a problem hiding this comment.
No need to ref count here since you don't clone. Also you could use a OnceCell since you won't be modifying more than once.
There was a problem hiding this comment.
Thanks so much! This has been applied in 36df31b
examples/rust/src/main.rs
Outdated
| ); | ||
|
|
||
| // Extracting the default pubsub topic | ||
| let default_pubsub_topic: Arc<RefCell<String>> = Arc::new(RefCell::new(String::from(""))); |
examples/rust/src/main.rs
Outdated
| *version.borrow_mut() = data.to_string(); | ||
| }; | ||
| let cb = get_trampoline(&closure); | ||
| waku_set_user_data(&mut ctx, &closure as *const _ as *const c_void); |
There was a problem hiding this comment.
I think it should be possible to get rid of this. See experiment here: https://github.com/richard-ramos/test_rust_ffi/blob/af098508acfae181df508eee524d75f70af68010/rustlib/src/lib.rs#L29-L38
There was a problem hiding this comment.
It looks beautiful indeed!
9 tasks
Ivansete-status
force-pushed
the
cbindings-rust
branch
from
653a712
to
9a2cfdb
Compare
Ivansete-status
changed the title
richard-ramos
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to show how the
libwakucan be used from Rust.So far, it performs the following points:
waku_new(create waku node.)waku_version(extract default pubsub topic to the Rust space.)waku_default_pubsub_topic(extract default pubsub topic to the Rust space.)The "trampoline" technique is being used in order to properly pass Rust closures as callbacks to the
libwaku. Therefore, we don't have the same concise code that we can achieve in cpp but it is indeed feasible. The code can become more concise by definingmacros!and the idea for the next step would be to properly expose a safe API to the user and leave the unsafe code managed internally.Notice that this PR also includes changes in
libwakuthat make it avoid the use of global variables, as stated in the next recommendation: #1865 (comment). This should definitely go in a separate PR.cc - @jm-clius @fryorcraken @alrevuelta @vpavlin @NagyZoltanPeter @gabrielmer