You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While rest api nwaku implementation is segregated by endpoints they implements their own types one-by-one.
This can be misleading adds complexity by code duplication and does not reflects one rest-api for Waku node as common.
Details
Ongoing task #2120 track normalize of openapi specifications and documentation.
This task tries to address and follow up that changes.
[ ] Reorganize types into common place
[ ] Remove type duplications
[ ] Enforce common naming scheme
[ ] Easy marshalling/de-marshalling code for api types, remove duplications of code/copy-pastes
Acceptance criteria
[ ] No change in functionality
[ ] All tests are passed
[ ] Alignment with go-waku and js-waku done in case of naming changes on api level.
The text was updated successfully, but these errors were encountered:
Downprio!
Rest api specification is moved to https://github.com/waku-org/waku-rest-api
Original PR of spec effort: #2124 had several comments that effects rest-api types and interfaces. Until those are not agreed and applied to the specification this issue can be postponed.
Background
While rest api nwaku implementation is segregated by endpoints they implements their own types one-by-one.
This can be misleading adds complexity by code duplication and does not reflects one rest-api for Waku node as common.
Details
Ongoing task #2120 track normalize of openapi specifications and documentation.
This task tries to address and follow up that changes.
[ ] Reorganize types into common place
[ ] Remove type duplications
[ ] Enforce common naming scheme
[ ] Easy marshalling/de-marshalling code for api types, remove duplications of code/copy-pastes
Acceptance criteria
[ ] No change in functionality
[ ] All tests are passed
[ ] Alignment with go-waku and js-waku done in case of naming changes on api level.
The text was updated successfully, but these errors were encountered: