Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest): fix bug in rest api when sending rln message #2169

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix(rest): fix bug in rest api when sending rln message #2169

merged 2 commits into from
Oct 30, 2023

Conversation

alrevuelta
Copy link
Contributor

Description:

  • Fix bug in rest api causing rln messages to be rejected.
  • Message without proof was being included due to a minor bug.

@github-actions
Copy link

github-actions bot commented Oct 30, 2023 •
edited

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2169

Built from 7c8230e

gabrielmer
gabrielmer approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tried it and fixes the issue :)

Thanks so much!

vpavlin
vpavlin approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@vpavlin vpavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@alrevuelta alrevuelta merged commit 250e8b9 into master Oct 30, 2023
8 checks passed
@alrevuelta alrevuelta deleted the fix-rln-rest branch October 30, 2023 15:19
gabrielmer pushed a commit that referenced this pull request Nov 7, 2023
@alrevuelta @gabrielmer
fix(rest): fix bug in rest api when sending rln message (#2169)
33decd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpavlin vpavlin vpavlin approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

@rymnc rymnc Awaiting requested review from rymnc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alrevuelta @vpavlin @gabrielmer