Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve cluster id, shards, topics flow #2183

Closed
3 tasks done
SionoiS opened this issue Nov 3, 2023 · 2 comments · Fixed by #2187
Closed
3 tasks done

chore: improve cluster id, shards, topics flow #2183

SionoiS opened this issue Nov 3, 2023 · 2 comments · Fixed by #2187
Assignees
@SionoiS
Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details

Comments

@SionoiS
Copy link
Contributor

SionoiS commented Nov 3, 2023 •
edited

Background

I feel like the information flow for cluster and shard could be simplified.

Details

Cluster id and shards are both specified in the config. What happen if they disagree?
Waku metadata, relay and discv5 must be updated and not conflict with each other WRT shards.

Acceptance criteria

  • Disallow conflicting cluster Id and topics
  • Refactor testing so that cluster and shard are easy to setup.
  • Simplify cluster and shard setup for all protocols.
@SionoiS SionoiS added the E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details label Nov 3, 2023
@SionoiS SionoiS self-assigned this Nov 3, 2023
@SionoiS SionoiS mentioned this issue Nov 6, 2023
Merged
6 tasks
@SionoiS
Copy link
Contributor Author

SionoiS commented Nov 20, 2023

Weekly Update

  • achieved: Various tests updates and fixes.
  • next: Figure out why CI passes locally only.

@SionoiS
Copy link
Contributor Author

SionoiS commented Nov 21, 2023

Weekly Update

  • achieved: last bug squashed and PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SionoiS SionoiS

Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: improving node setup w.r.t sharding information waku-org/nwaku
1 participant
@SionoiS