Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: discv5 filter peer by capability #2186

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Nov 3, 2023

Description

RFC#31 specify that discv5 must filter out ENRs that don't have waku2 field or empty capability list.

Changes

  • Filter predicate now reject peers with empty capability list.
  • Fixed test
  • Refactor shardingPredicate proc

Closes #2179

@SionoiS SionoiS added the E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details label Nov 3, 2023
@SionoiS SionoiS self-assigned this Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2186

Built from 946fe76

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🔥 Thank you!

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks for it!

tests/test_waku_discv5.nim Show resolved Hide resolved
@SionoiS SionoiS merged commit 200a11d into master Nov 6, 2023
9 of 10 checks passed
@SionoiS SionoiS deleted the feat--filter-peer-by-cap branch November 6, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(discv5): filter peer by capability
3 participants