bug: lack of error checking in publish

[alrevuelta]

If I post a message using autosharding but with a wrong contentTopic like the one below.

 curl -X POST "http://127.0.0.1:8645/relay/v1/auto/messages" \
 -H "content-type: application/json" \
 -d '{"payload":"ZXhhbXBsZQ==","contentTopic":"bbbbb"}'

It errors silently:

2023-11-07 13:53:57 ERR 2023-11-07 12:53:57.141+00:00 Autosharding error                         topics="waku node" tid=1 file=waku_node.nim:322 error="invalid format: topic must start with slash"

But the API call still returns OK, which is obviously wrong, since the message wasn't published.

Mainly due to this:

nwaku/waku/node/waku_node.nim

Lines 320 to 323 in 6da1aee

	let pubsubTopic = pubsubTopicOp.valueOr:
	getShard(message.contentTopic).valueOr:
	error "Autosharding error", error=error
	return

Solution:

• Return an error in the REST API if the message was not published due to an autosharding error.

[gabrielmer]

Weekly Update

• achieved: reproduced, investigated and started improving error handling
• next: continue with the implementation

[gabrielmer]

Weekly Update

• achieved: fixed compilation errors, got it to work and tested it
• next: add test cases to the codebase and open PR

[gabrielmer]

Weekly Update

• achieved: added test, fixed bug, started fixing non-compiling tests in dependent areas of the code
• next: finish adapting dependent tests to the new behavior and proc signatures