docs: rewrite for clarity, update screenshots #2206
Conversation
docs/tutorial/pre-requisites-of-running-on-chain-spam-protected-chat2.md
Outdated
Show resolved
Hide resolved
|
|
||
| If you already have an Ethereum account with sufficient ethers on the Sepolia testnet then you can skip the first two sections. | ||
| ## Creating Sepolia Ethereum Account and obtaining its private key | ||
| If you already have an Ethereum account with sufficient Sepolia ETH, you can skip 1 and 2. |
There was a problem hiding this comment.
Does the account also have to be in Metamask? Further instructions assume this.
There was a problem hiding this comment.
Most way to create Eth account don't allow to extract private key (for obvious reasons).
There was a problem hiding this comment.
I've removed these If...skip lines. This guide (3 guides, in fact) only makes sense within the context of other instructions and it should be clear in those instructions which of these steps are necessary or not.
For now, I'm only aiming to update what we have for clarity and accuracy, but the docs team should contextualize these within our docs site soon.
| If you already have an Ethereum account with sufficient ethers on the Sepolia testnet then you can skip the first two sections. | ||
| ## Creating Sepolia Ethereum Account and obtaining its private key | ||
| If you already have an Ethereum account with sufficient Sepolia ETH, you can skip 1 and 2. | ||
| If you already have an Ethereum node on the Sepolia testnet, you can skip 3. |
There was a problem hiding this comment.
If "skip 3" here means "follow 1 and 2, but skip 3", should we move this sentence to the beginning of step 3?
There was a problem hiding this comment.
Good point. I've opted to remove these conditionals altogether. See my previous comment.
docs/tutorial/pre-requisites-of-running-on-chain-spam-protected-chat2.md
Outdated
Show resolved
Hide resolved
docs/tutorial/pre-requisites-of-running-on-chain-spam-protected-chat2.md
Outdated
Show resolved
Hide resolved
docs/tutorial/pre-requisites-of-running-on-chain-spam-protected-chat2.md
Outdated
Show resolved
Hide resolved
| 14. Click on Export Private Key. | ||
|
|
||
|  | ||
| You will be shown the private key. Copy it as needed. |
There was a problem hiding this comment.
What does "as needed" mean here? I'd add a note on a) where this key will be pasted and why; b) why this is not a security concern (I hope it's not).
There was a problem hiding this comment.
Very good point. This is within the context of a convenience tool for RLN registration that uses this key only for a registration on the testnet. Preferably the context in which this guide is linked should explain the context and dangers. However, I've added some context and warning in 4d921d9.
docs/tutorial/pre-requisites-of-running-on-chain-spam-protected-chat2.md
Outdated
Show resolved
Hide resolved
docs/tutorial/pre-requisites-of-running-on-chain-spam-protected-chat2.md
Outdated
Show resolved
Hide resolved
docs/tutorial/pre-requisites-of-running-on-chain-spam-protected-chat2.md
Outdated
Show resolved
Hide resolved
docs/tutorial/pre-requisites-of-running-on-chain-spam-protected-chat2.md
Outdated
Show resolved
Hide resolved
|
|
||
| 5. You can find the endpoints for the hosted node using https and wss. The wss endpoint is the relevant one for connecting the waku node to the RLN contract on Sepolia network. Like follows: | ||
| Both Https and WebSockets endpoints are available. Waku requires the WebSockets endpoint. |
There was a problem hiding this comment.
I believe clicking websocket reset the network to mainnet. Might want to change the order
Some rewrites for clarity.
Updates screenshots where necessary (especially for the Infura workflow).