Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow text/plain contentType for rest request's body types #2207

Closed
NagyZoltanPeter opened this issue Nov 9, 2023 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@NagyZoltanPeter
Copy link
Contributor

Background

@weboko
"nwaku does not allow cross origin requests explicitly.
Because of that browser should send request with no-cors mode which downgrades request to Content-Type = text/plain;charset=UTF-8
nwaku of course rejects with it making it impossible to interact "

Details

Normally nwaku rest interface expect application/json content types but nothing prevent to attempt interpret plain text body types convert as from json format. Of course if something will not match we need to return specific error.

Acceptance criteria

  • all previous functionality must keep working, but rest request with text/plain contentType descriptor must be accepted either.
@NagyZoltanPeter
Copy link
Contributor Author

Weekly Update

achieved:
next: Allow text/plain contentType on RestApi is on PR, libwaku Fedora build issue

@chair28980 chair28980 added the enhancement New feature or request label Nov 14, 2023
@NagyZoltanPeter
Copy link
Contributor Author

Weekly Update

achieved: Better support for js-waku using RestApi: Allow text/plain contentType
next: Bandwidth management preparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants