Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Compilation failure fix. #2222

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

AlejandroCabeza
Copy link
Contributor

@AlejandroCabeza AlejandroCabeza commented Nov 15, 2023

Description

There were some missing keywords that slipped by in recent PRs, making compilation fail. This PR adds those keywords.
There are still some issues within the tests, meaning:

  • Some tests are failing.
  • Some tests are not being run.

I'm checking those right as I finish publishing this PR but, if you consider it a good idea, we can merge this in the meantime, so other PRs' jobs are not blocked.

Changes

  • Add missing keywords.

@AlejandroCabeza AlejandroCabeza self-assigned this Nov 15, 2023
@AlejandroCabeza AlejandroCabeza changed the title tAdd missing keywords making tests compilation fail. fix(tests): Add missing keywords making tests compilation fail. Nov 15, 2023
@AlejandroCabeza AlejandroCabeza changed the title fix(tests): Add missing keywords making tests compilation fail. fix(tests): Compilation failure fix. Nov 15, 2023
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2222

Built from 21ea25e

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@AlejandroCabeza AlejandroCabeza merged commit a5da1fc into master Nov 15, 2023
16 of 20 checks passed
@AlejandroCabeza AlejandroCabeza deleted the fix-missing-test-keywords branch November 15, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants