Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(relay): Failing protocol tests #2224

Merged
merged 3 commits into from
Nov 16, 2023
Merged

fix(relay): Failing protocol tests #2224

merged 3 commits into from
Nov 16, 2023

Conversation

AlejandroCabeza
Copy link
Contributor

Description

Fix failing protocol tests.

Changes

  • Ignore failing test.
  • Update payload size values.

@AlejandroCabeza AlejandroCabeza self-assigned this Nov 15, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2224

Built from ffc1ffc

@gabrielmer gabrielmer self-requested a review November 16, 2023 12:31
gabrielmer
gabrielmer approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AlejandroCabeza AlejandroCabeza merged commit c9e869f into master Nov 16, 2023
10 checks passed
@AlejandroCabeza AlejandroCabeza deleted the fix-failing-tests branch November 16, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SionoiS SionoiS SionoiS approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

Assignees

@AlejandroCabeza AlejandroCabeza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlejandroCabeza @SionoiS @gabrielmer