Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: postres driver allow setting the max number of connection from a parameter #2246

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

Ivansete-status
Copy link
Collaborator

Description

It is more handy to be able to easily change the maximum number of PostgreSQL connections a nwaku node can handle simultaneously.

Changes

  • New wakunode2 parameter: store-max-num-db-connections

Copy link

This PR may contain changes to configuration options of one of the apps.

If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed.

Please also make sure the label release-notes is added to make sure any changes to the user interface are properly announced in changelog and release notes.

Copy link

This PR may contain changes to database schema of one of the drivers.

If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues.

Please make sure the label release-notes is added to make sure upgrade instructions properly highlight this change.

@Ivansete-status Ivansete-status self-assigned this Nov 24, 2023
Copy link

github-actions bot commented Nov 24, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2246

Built from 8576c4c

@Ivansete-status Ivansete-status marked this pull request as ready for review November 24, 2023 12:54
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much! :))

Copy link
Contributor

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@Ivansete-status Ivansete-status merged commit b31c182 into master Nov 24, 2023
9 of 10 checks passed
@Ivansete-status Ivansete-status deleted the making-max-db-conn-configurable branch November 24, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants