bug: Lightpush's publish type error

[AlejandroCabeza]

Problem

WakuLightPushClient.publish fails with "dial failure" when peer is PeerId.

Impact

...

To reproduce

1. Instantiate two Switch, one will act as serverSwitch and the other as clientSwitch.
2. Instantiate a WakuLightPush and a WakuLightPushClient, using the respective switches.
3. Send a publish request using serverSwitch.peerInfo.toRemotePeerInfo().peerId.
4. The response will be a "dial failure".

In step 3, if using serverSwitch.peerInfo.toRemotePeerInfo(), it will be successful.

Expected behavior

The method works fine when sending a RemotePeerId instead of PeerId. That is weird given RemotePeerId contains PeerId, hence I expected the method to behave exactly the same.

nwaku version/commit hash

• Wakunode: v0.22.0-rc.0-26-g3dcfbf
• Git: 4cbc649 | branch
• PR: test(lightpush): Lightpush functional tests #2252

[gabrielmer]

@AlejandroCabeza is there a test/branch for this somewhere we can use to reproduce?

[AlejandroCabeza]

@AlejandroCabeza is there a test/branch for this somewhere we can use to reproduce?

It's been a bit so I can't anything extra aside from what I posted. You weren't able to reproduce it?

[gabrielmer]

It's been a bit so I can't anything extra aside from what I posted. You weren't able to reproduce it?

I was looking for the specific piece of code where it is supposed to reproduce instead of writing it, which is very error prone. No worries then :))

In future cases I think it would be better to provide the code so we all run the same thing and are on the same page.

[AlejandroCabeza]

It's been a bit so I can't anything extra aside from what I posted. You weren't able to reproduce it?

I was looking for the specific piece of code where it is supposed to reproduce instead of writing it, which is very error prone. No worries then :))

In future cases I think it would be better to provide the code so we all run the same thing and are on the same page.

Generally I tend to leave a test for these cases, I don't know why I didn't on this occasion 🤔