Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dockerfile): update dockerignore and base image #2262

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

vpavlin
Copy link
Member

@vpavlin vpavlin commented Nov 30, 2023

Description

When building docker image, the COPY command would also bring in nimcache/ and librln* which resulted in failures.

This does not happen in fresh repo clones, but after you run a build in the repo dir and attempt to build a container, it will fail

121.7 /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/std/src/../../backtrace/src/symbolize/gimli/mmap_unix.rs:19:(.text._ZN3std12backtrace_rs9symbolize5gimli4mmap17h7e46d9a51e3a4761E+0x1a4): undefined reference to `mmap64'
122.2 collect2: error: ld returned 1 exit status
122.2 Error: execution of an external program failed: 'gcc  @networkmonitor_linkerArgs.txt'
122.3 stack trace: (most recent call last)
122.3 /app/vendor/nimbus-build-system/vendor/Nim/lib/system/nimscript.nim(429, 18)
122.3 /app/waku.nimble(71, 15) networkmonitorTask
122.3 /app/waku.nimble(35, 8)  buildBinary
122.3 /app/vendor/nimbus-build-system/vendor/Nim/lib/system/nimscript.nim(273, 7) exec
122.3 /app/vendor/nimbus-build-system/vendor/Nim/lib/system/nimscript.nim(273, 7) Error: unhandled exception: FAILED: nim c --out:build/networkmonitor  -d:chronicles_colors:none -d:insecure -d:postgres --verbosity:0 --hints:off -d:chronicles_log_level=TRACE -d:git_version="v0.22.0-rc.0-3-g2cb098" -d:release --passL:librln_v0.3.4.a --passL:-lm apps/networkmonitor/networkmonitor.nim [OSError]
122.3 make: *** [Makefile:206: networkmonitor] Error 1

Changes

  • add nimcache and librln* to .dockerignore
  • update the alpine base image

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Super tricky issue! Thanks for it :)!

Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! Detective @vpavlin

@vpavlin vpavlin merged commit c86dc44 into master Dec 1, 2023
8 checks passed
@vpavlin vpavlin deleted the bug/dockerignore branch December 1, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants