Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: vendor bump for 0.23.0 #2274

Merged
merged 21 commits into from
Dec 14, 2023
Merged

chore: vendor bump for 0.23.0 #2274

merged 21 commits into from
Dec 14, 2023

Conversation

Ivansete-status
Copy link
Collaborator

Description

Regular vendor bumping for 0.23.0

Issue

closes #2266

@Ivansete-status Ivansete-status self-assigned this Dec 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2274

Built from 6193ad5

@Ivansete-status Ivansete-status force-pushed the vendor-bump branch 2 times, most recently from d528605 to fd83795 Compare December 7, 2023 14:40
@github-actions GitHub Actions
Copy link

This PR may contain changes to configuration options of one of the apps.

If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed.

Please also make sure the label release-notes is added to make sure any changes to the user interface are properly announced in changelog and release notes.

@Ivansete-status Ivansete-status force-pushed the vendor-bump branch 2 times, most recently from e5b5f8b to 72db8b5 Compare December 12, 2023 14:52
@Ivansete-status Ivansete-status marked this pull request as ready for review December 13, 2023 07:28
@Ivansete-status
Copy link
Collaborator Author

Morning all!
@rymnc - Kindly take a close look at this PR when you have some time :) Particularly interested in the changes around:

  • waku/waku_rln_relay/*
  • tests/waku_rln_relay/*

rymnc
rymnc approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass :)

NagyZoltanPeter
NagyZoltanPeter approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Hard work done as can seen! Thank you for this!!!

jm-clius
jm-clius approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A big one! Approving so it can be merged - know how horrible rebasing this can be. Good job.

@Ivansete-status Ivansete-status merged commit 385daf1 into master Dec 14, 2023
9 of 10 checks passed
@Ivansete-status Ivansete-status deleted the vendor-bump branch December 14, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymnc rymnc rymnc approved these changes

@jm-clius jm-clius jm-clius approved these changes

@NagyZoltanPeter NagyZoltanPeter NagyZoltanPeter approved these changes

@SionoiS SionoiS Awaiting requested review from SionoiS

@alrevuelta alrevuelta Awaiting requested review from alrevuelta

@gabrielmer gabrielmer Awaiting requested review from gabrielmer

Assignees

@Ivansete-status Ivansete-status

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump vendor dependencies for release 0.23.0
4 participants
@Ivansete-status @rymnc @jm-clius @NagyZoltanPeter