chore: log messageHash for lightpush request received #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanyaprem
requested review from
gabrielmer,
NagyZoltanPeter and
Ivansete-status
chaitanyaprem
changed the title
|
You can find the image built from this PR at Built from 17591fa |
gabrielmer
approved these changes
Jan 24, 2024
|
js CI seems to be failing? |
Yes! Please go ahead and merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While debugging message loss issues with status, had noticed that messageHash is not logged for lightpush which helps in debugging to know if message is received by the fleet nodes.
Changes
Note: Tested by using a go-waku lightpush client to ensure messageHash is logged properly