chore: improved error handling when config uses cluster-id and pubsub topics #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from eff1a21 |
SionoiS
force-pushed
the
chore--improved-error-handling
branch
from
bd98bfc
to
c08e807
Compare
gabrielmer
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
LGTM, thanks so much!
Also noticed that this change would fix also #2311
Tested it and indeed it resolves that issue too 🥳
Ivansete-status
approved these changes
Jan 29, 2024
I added a proc |
|
thank you! will look into resolving js-waku interop tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An error is now returned when trying to do for example;
--cluster-id=2 --pubsub-topic=/waku/2/rs/1/7--cluster-id=0 --pubsub-topic=/waku/2/rs/1/7--cluster-id=2 --content-topic=/myapp/2/mytopic/proto--cluster-id=0 --content-topic=/myapp/2/mytopic/protoN.B. This in addition to shard errors
Tracking #2259