bug: KEYSTORE_PASSWORD env variable is not effective

[romanzac]

Problem

When I was following instructions to run Waku node with Docker compose, I got error messages indicating it was not possible to generate RLN proof.

When I added "correct" variable name "RLN_RELAY_CRED_PASSWORD" to my existing environment with KEYSTORE_PASSWORD, I still cannot get RLN proof generated. It looks there is some compatibility support in the code not behaving exactly as expected.

Finally this set of variables worked for me:
ETH_CLIENT_ADDRESS, ETH_TESTNET_KEY, RLN_RELAY_CRED_PASSWORD

Instructions followed at:
https://docs.waku.org/guides/nwaku/run-docker-compose/

Impact

low occurrence, medium severity

To reproduce

Follow instructions at https://docs.waku.org/guides/nwaku/run-docker-compose/

Expected behavior

Variable name in sync with documentation. RLN proof gets generated if KEYSTORE_PASSWORD is supported.

Screenshots/logs

DBG 2024-01-26 11:54:42.149+00:00 Received error response from handler tid=1 file=serverprivate.nim:307 status=500 meth=POST peer=172.24.0.1:55614 uri=/relay/v1/auto/messages error_status="500 Internal Server Error" error_content_type=text/plain error_message="Failed to publish: error appending RLN proof to message"
DBG 2024-01-26 11:54:42.504+00:00 bytes topics="waku rln_relay conversion_utils" tid=1 file=conversion_utils.nim:110 bytes="[130, 157, 179, 101, 0, 0, 0, 0]"

nwaku version/commit hash

harbor.status.im/wakuorg/nwaku:v0.24.0

[romanzac]

1. Mention to “KEYSTORE_PASSWORD” has been removed from https://docs.waku.org/guides/nwaku/run-docker-compose/
2. "RLN_RELAY_CRED_PASSWORD" is used instead of “KEYSTORE_PASSWORD” at https://github.com/waku-org/go-waku-compose/blob/master/register_rln.sh

We can close this issue, as it cannot be simulated anymore.