Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make max message size configurable only for clusterIds different than 1 #2406

Closed
gabrielmer opened this issue Feb 8, 2024 · 1 comment · Fixed by #2424
Closed
Assignees

Comments

@gabrielmer
Copy link
Contributor

gabrielmer commented Feb 8, 2024

Background

In cluster-ids different than 1 (aka not the Waku Network), we want the max size of a WakuMessage to be configurable.
For cluster id one, it should comply with the hard limit of the Waku Network.

We should also update the checks at the REST API handler to use the configurable value and not the default limit.

Acceptance criteria

  • max message size should be configurable outside of cluster-id 1
  • message validation checks should use the configurable value instead of the hardcoded default
@gabrielmer
Copy link
Contributor Author

This is the proc that has to be modified at the REST level:

image

It also doesn't have to be async

@gabrielmer gabrielmer changed the title chore: make MaxWakuMessageSize configurable chore: make MaxWakuMessageSize configurable only for clusterIds different than 1 Feb 9, 2024
@gabrielmer gabrielmer changed the title chore: make MaxWakuMessageSize configurable only for clusterIds different than 1 chore: make max message size configurable only for clusterIds different than 1 Feb 9, 2024
@gabrielmer gabrielmer self-assigned this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant