chore(rln-relay-v2): add tests for serde #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
added
the
E:RLN on mainnet
|
You can find the image built from this PR at Built from d1fecfa |
alrevuelta
approved these changes
Feb 13, 2024
Ivansete-status
approved these changes
Feb 13, 2024
Co-authored-by: Ivan FB <128452529+Ivansete-status@users.noreply.github.com>
arnetheduck
reviewed
Feb 13, 2024
| @@ -69,8 +69,8 @@ when defined(rln_v2): | |||
| ## the serialization is done as instructed in https://github.com/kilic/rln/blob/7ac74183f8b69b399e3bc96c1ae8ab61c026dc43/src/public.rs#L146 | |||
| ## [ id_key<32> | id_index<8> | epoch<32> | signal_len<8> | signal<var> ] | |||
| let memIndexBytes = toBytes(uint64(memIndex), Endianness.littleEndian) | |||
| let userMessageLimitBytes = toBytes(uint64(userMessageLimit), Endianness.littleEndian) | |||
| let messageIdBytes = toBytes(uint64(messageId), Endianness.littleEndian) | |||
| let userMessageLimitBytes = cast[array[32, byte]](toBytes(uint64(userMessageLimit), Endianness.littleEndian)) | |||
There was a problem hiding this comment.
using cast is a good way to introduce undefined behavior - it should be avoided in most cases - array[...](toBytes...) will work iff this is a compatible conversion, otherwise you need to construct the array in some other way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes tests for the serde changes in rln-v2, including
toLeafandproofGen/proofVerifyChanges
proofGentoLeafHow to test
nim c --out:build/rln_v2_serde -r -d:chronicles_log_level=INFO --verbosity:0 --hints:off -d:git_version="v0.24.0-rc.0-35-g50308e" -d:release --passL:librln_v0.4.1.a --passL:-lm -d:rln_v2 tests/waku_rln_relay/rln_v2/test_rln_relay_v2_serde.nim(provided you ranRLN_V2=true make -j16 updatebefore)OR
RLN_V2=true make -j16 test