fix(rln-relay): graceful shutdown with non-zero exit code #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
|
You can find the image built from this PR at Built from 0593aac |
rymnc
force-pushed
the
graceful-non-zero-exit-code-rln
branch
from
c1ca0f4
to
2c176d7
Compare
rymnc
added
the
E:RLN on mainnet
gabrielmer
approved these changes
Feb 15, 2024
Ivansete-status
approved these changes
Feb 15, 2024
waku/waku_rln_relay/rln_relay.nim
Outdated
| rlnRelayCredPath*: string | ||
| rlnRelayCredPassword*: string | ||
| rlnRelayTreePath*: string | ||
| # defined in waku_archive, but do not want to import it here |
There was a problem hiding this comment.
Sorry I can't quite understand the comment:)
Co-authored-by: Ivan FB <128452529+Ivansete-status@users.noreply.github.com>
NagyZoltanPeter
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows the pattern set by the waku_archive protocol, which propagates fatal error handling to appropriate protocols, without which the node goes into UB.
Changes
error_handlinginwaku_common, which is imported bywaku_archiveandwaku_rln_relay, exporting a typeOnFatalErrorHandleronFatalErrorActiontowaku_rln_relayHow to test