Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate DiscV5 and DNS Discovery from app.nim to waku_node.nim #2452

Closed
Ivansete-status opened this issue Feb 19, 2024 · 1 comment
Closed
Assignees

Comments

@Ivansete-status
Copy link
Collaborator

Background

Epic: #2420

Pre-condition

The following should be completed before starting this so that we can benefit from having a single configuration entry to the waku_node: #2441

Details

The DiscV5 and DNS Discovery are nowadays directly handled by the app.nim module. We need to migrate that logic so that they fall under waku_node module umbrella and therefore, it is easy to use them from both wakunode2 app and libwaku.

Notice that we can create new separate modules, if needed, because the waku_node.nim is getting quite long. In any case, the new modules should be created under the folder waku/node/.

@Ivansete-status
Copy link
Collaborator Author

This can be closed thanks to the previous merged PR's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants