fix: time on 32 bits architecture #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 901befe |
SionoiS
requested review from
jm-clius,
gabrielmer,
NagyZoltanPeter and
Ivansete-status
jm-clius
approved these changes
Feb 29, 2024
Ivansete-status
approved these changes
Feb 29, 2024
| timeInSecondsFloat64 = float64(secondsFloat) | ||
|
|
||
| ## Then | ||
| check: | ||
| getNanosecondTime(timeInSecondsInt) == lowResTimestamp |
There was a problem hiding this comment.
Why this check is not needed?
There was a problem hiding this comment.
Removed these tests, as they are in contradiction with the change ( allow using the function on 32bit )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #2476 for merging purpose.