fix: emit event when FILTER subscribe to a topic. #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SionoiS
changed the title
|
You can find the image built from this PR at Built from c67c0d0 |
Ivansete-status
approved these changes
Feb 29, 2024
richard-ramos
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
LGTM.
We need to take into account that this would only fix the scenario in which you subscribe against a known peer, however as described in #2491 (comment) if you rely on peer exchange to obtain the peers which you would use for subscribing to filter, then sadly you'd still get disconnected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Filter subscribe now trigger an topic subscription event which result in Waku Metadata being updated.
Previously light nodes would get disconnected because they had no shards specified in Waku Metadata.
Close #2491