Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres): import under feature flag #2500

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Mar 5, 2024

Description

Previously, the postgres migration was imported outside of the feature flag and hence caused a dependency on the libpq library

Changes

  • moved import to under the feature flag

@rymnc rymnc self-assigned this Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2500

Built from eda411f

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!!

@rymnc rymnc merged commit e692edf into master Mar 6, 2024
9 of 10 checks passed
@rymnc rymnc deleted the fix-postgres-import branch March 6, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants