fix(rln-relay): make nullifier log abide by epoch ordering #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
added
the
E:RLN on mainnet
2 tasks
|
You can find the image built from this PR at Built from a06cd42 |
rymnc
changed the title
alrevuelta
requested changes
Mar 6, 2024
| # check if the epoch exists | ||
| if not rlnPeer.nullifierLog.hasKey(externalNullifier): | ||
| let nullifier = proofMetadata.nullifier |
There was a problem hiding this comment.
Maybe all this can be replace by something like (disregard types). getOrDefault might be useful.
return defaultTable.getOrDefault("epoch1", initTable[string, int]()).hasKey("key1")
A quick example would be something like this.
import tables
var defaultTable: Table[string, Table[string, int]] = {"epoch1":{"key1": 3, "key2": 3}.toTable,
"epoch2": {"key3": 3, "key4": 3}.toTable}.toTable
echo defaultTable.getOrDefault("epoch1", initTable[string, int]()).hasKey("key1")
# true
echo defaultTable.getOrDefault("epoch1", initTable[string, int]()).hasKey("key200")
# false
echo defaultTable.getOrDefault("epoch5", initTable[string, int]()).hasKey("key1")
# false
just an idea though, at your discretion.
There was a problem hiding this comment.
not sure thats addressed there. in any case not blocking.
There was a problem hiding this comment.
we don't actually need to get the value from the nullifierLog table, just check if it exists.
Ivansete-status
approved these changes
Mar 6, 2024
alrevuelta
approved these changes
Mar 6, 2024
| # check if the epoch exists | ||
| if not rlnPeer.nullifierLog.hasKey(externalNullifier): | ||
| let nullifier = proofMetadata.nullifier |
There was a problem hiding this comment.
not sure thats addressed there. in any case not blocking.
Co-authored-by: Ivan FB <128452529+Ivansete-status@users.noreply.github.com>
rymnc
force-pushed
the
rln-relay-nullifier-log-fix
branch
from
378100a
to
c8bc4a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using theepochas the key for the nullifierLog,externalNullifierwas being used. This could lead to a node only accepting one valid message sent during an epoche, and reject all other messages sent during epoche.Made the NullifierLog properly map from Epoch to Nullifiers instead of ExternalNullifier to ProofMetadata.
Optimized by nesting the hashmap to locate duplicates faster instead of searching an array.
Changes
OrderedTable[Epoch, Table[Nullifier, ProofMetadata]]