Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(2491): Fix metadata protocol disconnecting light nodes #2533

Merged
merged 5 commits into from
Mar 19, 2024
Merged

fix(2491): Fix metadata protocol disconnecting light nodes #2533

merged 5 commits into from
Mar 19, 2024

Conversation

AlejandroCabeza
Copy link
Contributor

Description

Fix for metadata protocol disconnecting light nodes: Now non-relay peers won't be checked for shardId.
Closes: #2491

Changes

  • Fix the issue
  • Add test cases covering the issue

@AlejandroCabeza AlejandroCabeza self-assigned this Mar 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2533-rln-v2-false

Built from df54bbc

@AlejandroCabeza AlejandroCabeza requested review from SionoiS and richard-ramos and removed request for NagyZoltanPeter March 14, 2024 16:59
@AlejandroCabeza AlejandroCabeza changed the base branch from master to test-discv5 March 14, 2024 17:38
@AlejandroCabeza AlejandroCabeza changed the base branch from test-discv5 to master March 14, 2024 17:38
SionoiS
SionoiS approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is good but organizationally I would prefer changes.

Thanks!

waku/node/waku_node.nim Outdated Show resolved Hide resolved
waku/node/peer_manager/peer_manager.nim Outdated Show resolved Hide resolved
tests/node/peer_manager/test_peer_manager.nim Outdated Show resolved Hide resolved
Ivansete-status
Ivansete-status approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it!
I just added some recommendations that I hope you find useful.
Also interesting to make the test part of the CI by either:

  • properly importing the new test_peer_manager module.
    or
  • Following SP's suggestion.

waku/node/peer_manager/peer_manager.nim Outdated Show resolved Hide resolved
@AlejandroCabeza AlejandroCabeza force-pushed the fix/issue/2491-metadata-disconnecting-light-clients branch from f20ad38 to eb1ef5c Compare March 19, 2024 14:07
@AlejandroCabeza AlejandroCabeza merged commit 33774fa into master Mar 19, 2024
11 of 15 checks passed
@AlejandroCabeza AlejandroCabeza deleted the fix/issue/2491-metadata-disconnecting-light-clients branch March 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SionoiS SionoiS SionoiS approved these changes

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@richard-ramos richard-ramos richard-ramos approved these changes

@vpavlin vpavlin Awaiting requested review from vpavlin

Assignees

@AlejandroCabeza AlejandroCabeza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: metadata protocol will disconnect light clients
4 participants
@AlejandroCabeza @richard-ramos @SionoiS @Ivansete-status