Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove subscription queue limit #2551

Merged
merged 2 commits into from
Mar 25, 2024
Merged

fix: remove subscription queue limit #2551

merged 2 commits into from
Mar 25, 2024

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Mar 25, 2024

Description

I removed the limit on the number of subscription events the queue can handle.

Close #2550

@SionoiS SionoiS self-assigned this Mar 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2551-rln-v2-true

Built from d2e2797

fbarbu15
fbarbu15 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@fbarbu15 fbarbu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with quay.io/wakuorg/nwaku-pr:2551-rln-v2-true and it works fine even with > 100 flags

Ivansete-status
Ivansete-status approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!
As a reference, 0 means "no limit":

https://github.com/status-im/nim-chronos/blob/7b02247ce74d5ad5630013334f2e347680b02f65/chronos/asyncsync.nim#L475

@SionoiS SionoiS merged commit 94ff5ea into master Mar 25, 2024
13 of 15 checks passed
@SionoiS SionoiS deleted the fix--remove-subscription-queue-limit branch March 25, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarbu15 fbarbu15 fbarbu15 approved these changes

@Ivansete-status Ivansete-status Ivansete-status approved these changes

Assignees

@SionoiS SionoiS

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@SionoiS @fbarbu15 @Ivansete-status